kadirozde commented on code in PR #1531:
URL: https://github.com/apache/phoenix/pull/1531#discussion_r1072753569
##########
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -807,14 +810,39 @@ private void handleLocalIndexUpdates(TableName table,
miniBatchOp.addOperationsFromCP(0, localUpdates.toArray(new
Mutation[localUpdates.size()]));
}
}
+
+ private boolean isPartialUncoveredIndexUpdate(PhoenixIndexMetaData
indexMetaData,
+ MiniBatchOperationInProgress<Mutation> miniBatchOp) throws
IOException {
+ int indexedColumnCount = 0;
+ for (IndexMaintainer indexMaintainer :
indexMetaData.getIndexMaintainers()) {
+ indexedColumnCount += indexMaintainer.getIndexedColumns().size();
+ }
+ Set<ColumnReference> indexedColumns = new
HashSet<ColumnReference>(indexedColumnCount);
+ for (IndexMaintainer indexMaintainer :
indexMetaData.getIndexMaintainers()) {
+ indexedColumns.addAll(indexMaintainer.getIndexedColumns());
+ }
+ for (int i = 0; i < miniBatchOp.size(); i++) {
+ if (miniBatchOp.getOperationStatus(i) == IGNORE) {
+ continue;
+ }
+ Mutation m = miniBatchOp.getOperation(i);
+ if (!this.builder.isEnabled(m)) {
+ continue;
+ }
+ for (ColumnReference indexedColumn : indexedColumns) {
+ if (m.get(indexedColumn.getFamily(),
indexedColumn.getQualifier()).isEmpty()) {
+ return true;
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
