[ 
https://issues.apache.org/jira/browse/PHOENIX-6720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680771#comment-17680771
 ] 

ASF GitHub Bot commented on PHOENIX-6720:
-----------------------------------------

stoty commented on PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#issuecomment-1404137118

   We already have the DEFAULT_COLUMN_FAMILY property, where we specify column 
families in a table property.
   
   According to the grammar page:
   
   DEFAULT_COLUMN_FAMILY string option determines the column family used used 
when none is specified. The value is case sensitive. If this option is not 
present, a column family name of '0' is used.
   
   So we should stick to the same semantics, and not do the "normalize to 
uppercase when not double quoted" stuff here.
   
   We could argue that your current solution is more correct, but we should 
have a single way of handling families (at least in table properties)




> "create table" can't recreate column encoded tables that had columns dropped
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-6720
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6720
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 5.2.0, 5.1.3
>            Reporter: Istvan Toth
>            Assignee: Aron Attila Meszaros
>            Priority: Blocker
>
> For column encoded tables,create table generate column qualifier order.
> When moving data between instances, and the original table had some columns 
> removed, or swapped around, then the column qualifers in the table are not 
> guarenteed to start from the expected value and increase by 1 for each 
> column, based on the ordering of columns.
> This means that when we load a data table via HBase (i.e from a snaphsot), 
> and then execute the DDL created by the show create table, or by other means, 
> the column_qualifiers on the new table are going to point to the wrong Hbase 
> cell.
> We need to accept and use COLUMN_QUALIFIER properties for columns,  and 
> include them in in the show create table output for column encoded tables.
> We also need to accept and generate QUALIFIER_COUNTER for the tables.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to