[
https://issues.apache.org/jira/browse/PHOENIX-6720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681907#comment-17681907
]
ASF GitHub Bot commented on PHOENIX-6720:
-----------------------------------------
stoty commented on code in PR #1553:
URL: https://github.com/apache/phoenix/pull/1553#discussion_r1090229132
##########
phoenix-core/src/main/java/org/apache/phoenix/parse/ParseNodeFactory.java:
##########
@@ -289,22 +289,33 @@ public PropertyName propertyName(String familyName,
String propertyName) {
}
public ColumnDef columnDef(ColumnName columnDefName, String sqlTypeName,
boolean isNull, Integer maxLength, Integer scale, boolean isPK, SortOrder
sortOrder, String expressionStr, boolean isRowTimestamp) {
- return new ColumnDef(columnDefName, sqlTypeName, isNull, maxLength,
scale, isPK, sortOrder, expressionStr, isRowTimestamp);
+ return new ColumnDef(columnDefName, sqlTypeName, isNull, maxLength,
scale, isPK, sortOrder, expressionStr, null, isRowTimestamp);
}
+ public ColumnDef columnDef(ColumnName columnDefName, String sqlTypeName,
+ boolean isArray, Integer arrSize, Boolean
isNull,
+ Integer maxLength, Integer scale, boolean isPK,
+ SortOrder sortOrder, String expressionStr,
Integer cq, boolean isRowTimestamp) {
Review Comment:
I'd prefer 'encodedQualifier' or instead of 'cq' as a the variable name.
> "create table" can't recreate column encoded tables that had columns dropped
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-6720
> URL: https://issues.apache.org/jira/browse/PHOENIX-6720
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.2.0, 5.1.3
> Reporter: Istvan Toth
> Assignee: Aron Attila Meszaros
> Priority: Blocker
>
> For column encoded tables,create table generate column qualifier order.
> When moving data between instances, and the original table had some columns
> removed, or swapped around, then the column qualifers in the table are not
> guarenteed to start from the expected value and increase by 1 for each
> column, based on the ordering of columns.
> This means that when we load a data table via HBase (i.e from a snaphsot),
> and then execute the DDL created by the show create table, or by other means,
> the column_qualifiers on the new table are going to point to the wrong Hbase
> cell.
> We need to accept and use COLUMN_QUALIFIER properties for columns, and
> include them in in the show create table output for column encoded tables.
> We also need to accept and generate QUALIFIER_COUNTER for the tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
