virajjasani commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1223527757
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##########
@@ -748,6 +757,14 @@ public Long getEstimateInfoTimestamp() throws SQLException
{
}
}
+ /**
+ * Implementation of MutationPlan that is selected if
+ * 1) there are mutable indexes presented for the table,
+ * 2) auto commit is on,
+ * 3) the table is not transactional,
+ * 4) there is no WHERE clause, and
+ * 5) no LIMIT clause in the DELETE statement.
Review Comment:
every plan except `MultiRowDeleteMutationPlan` can have LIMIT and WHERE
correct?
i might have misread earlier, otherwise would have commented, sorry.
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##########
@@ -354,7 +354,11 @@ private List<PTable>
getClientSideMaintainedIndexes(TableRef tableRef) {
}
return Collections.emptyList();
}
-
+
+ /**
+ * Implementation of MutationPlan that is selected if there is no index
presented for a table
+ * and no LIMIT clause in the DELETE statement.
+ */
public class MultiRowDeleteMutationPlan implements MutationPlan {
Review Comment:
`the query is strictly point lookup` => `the query either has no WHERE
clause or it is strictly point lookup`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
