virajjasani commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1223562140
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##########
@@ -748,6 +757,14 @@ public Long getEstimateInfoTimestamp() throws SQLException
{
}
}
+ /**
+ * Implementation of MutationPlan that is selected if
+ * 1) there are mutable indexes presented for the table,
+ * 2) auto commit is on,
+ * 3) the table is not transactional,
+ * 4) there is no WHERE clause, and
+ * 5) no LIMIT clause in the DELETE statement.
Review Comment:
i see, `boolean runOnServer = isAutoCommit && !hasPreOrPostProcessing &&
.....`
so `!hasPreOrPostProcessing` is applicable to both
`MultiRowDeleteMutationPlan` and `ServerSelectDeleteMutationPlan`.
what this means is, if `hasPreOrPostProcessing` is true, only
`ClientSelectDeleteMutationPlan` will get selected.
`hasPreOrPostProcessing` is always true for LIMIT clause, alright this one
looks good, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
