[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730750#comment-17730750
]
ASF GitHub Bot commented on PHOENIX-6962:
-----------------------------------------
tkhurana commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1223579850
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##########
@@ -748,6 +756,12 @@ public Long getEstimateInfoTimestamp() throws SQLException
{
}
}
+ /**
+ * Implementation of MutationPlan that is selected if
+ * 1) auto commit is enabled as well as server side delete mutations are
enabled,
+ * 2) the table is not transactional,
+ * 3) there is neither WHERE clause nor LIMIT clause in the DELETE
statement.
Review Comment:
WHERE clause is allowed @jinggou
> Write javadoc for different mutation plans within DeleteCompiler.
> -----------------------------------------------------------------
>
> Key: PHOENIX-6962
> URL: https://issues.apache.org/jira/browse/PHOENIX-6962
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Reporter: Rushabh Shah
> Assignee: Jing Yu
> Priority: Minor
>
> There are multiple mutation plan within DeleteCompiler:
> # MultiRowDeleteMutationPlan
> # SingleRowDeleteMutationPlan
> # ServerSelectDeleteMutationPlan
> # ClientSelectDeleteMutationPlan
> It doesn't have javadocs explaining which mutation plan is selected for a
> given delete statement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
