[ 
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730726#comment-17730726
 ] 

ASF GitHub Bot commented on PHOENIX-6962:
-----------------------------------------

tkhurana commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1223550588


##########
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##########
@@ -354,7 +354,13 @@ private List<PTable> 
getClientSideMaintainedIndexes(TableRef tableRef) {
         }
         return Collections.emptyList();
     }
-    
+
+    /**
+     * Implementation of MutationPlan that is selected if
+     * 1) there is no index presented for a table,

Review Comment:
   Even immutable indexes can use this plan if the indexed columns can be 
evaluated from the query





> Write javadoc for different mutation plans within DeleteCompiler.
> -----------------------------------------------------------------
>
>                 Key: PHOENIX-6962
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6962
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>            Reporter: Rushabh Shah
>            Assignee: Jing Yu
>            Priority: Minor
>
> There are multiple mutation plan within DeleteCompiler:
>  # MultiRowDeleteMutationPlan
>  # SingleRowDeleteMutationPlan
>  # ServerSelectDeleteMutationPlan
>  # ClientSelectDeleteMutationPlan
> It doesn't have javadocs explaining which mutation plan is selected for a 
> given delete statement.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to