virajjasani commented on code in PR #1631:
URL: https://github.com/apache/phoenix/pull/1631#discussion_r1235536515


##########
phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java:
##########
@@ -369,6 +384,10 @@ private QueryPlan addPlan(PhoenixStatement statement, 
SelectStatement select, PT
                  * otherwise we just don't use this index (as opposed to 
trying to join back from
                  * the index table to the data table.
                  */
+                // Reset the state changes from the attempt above
+                indexTableRef.setHinted(false);

Review Comment:
   without this reset, the compiler might still end up using uncovered index 
right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to