virajjasani commented on code in PR #1631:
URL: https://github.com/apache/phoenix/pull/1631#discussion_r1235693485
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java:
##########
@@ -505,7 +505,15 @@ public static RowProjector compile(StatementContext
context, SelectStatement sta
} else {
isProjectEmptyKeyValue = where == null ||
LiteralExpression.isTrue(where) || where.requiresFinalEvaluation();
for (byte[] family : projectedFamilies) {
- projectColumnFamily(table, scan, family);
+ try {
+ if (table.getColumnFamily(family) != null) {
+ projectColumnFamily(table, scan, family);
+ }
+ } catch (ColumnFamilyNotFoundException e) {
+ if (!(tableRef.getTable().getIndexType() ==
IndexType.LOCAL || isHintedGlobalIndex(tableRef))) {
+ throw e;
+ }
Review Comment:
for else case, would a DEBUG log be helpful?
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexOptimizationIT.java:
##########
@@ -155,14 +155,13 @@ private void testOptimization(String dataTableName,
String dataTableFullName, St
- String expected =
- "CLIENT PARALLEL 1-WAY FULL SCAN OVER " + dataTableName +
"\n" +
- " SKIP-SCAN-JOIN TABLE 0\n" +
- " CLIENT PARALLEL 1-WAY RANGE SCAN OVER " +
indexTableName + " \\['a'\\]\n" +
- " SERVER FILTER BY FIRST KEY ONLY\n" +
- " DYNAMIC SERVER FILTER BY \\(\"" + dataTableName +
".T_ID\", \"" + dataTableName + ".K1\", \"" + dataTableName + ".K2\"\\) IN
\\(\\(\\$\\d+.\\$\\d+, \\$\\d+.\\$\\d+, \\$\\d+.\\$\\d+\\)\\)";
+ String expected =
+ "CLIENT PARALLEL 1-WAY RANGE SCAN OVER " + indexTableName
+ " ['a']\n" +
+ " SERVER MERGE [0.K3]\n" +
+ " SERVER FILTER BY FIRST KEY ONLY";
Review Comment:
do we not need `NO_INDEX_SERVER_MERGE` with `INDEX("dt" "it")` for this to
be changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
