tkhurana commented on code in PR #1575: URL: https://github.com/apache/phoenix/pull/1575#discussion_r1237617385
########## phoenix-core/src/it/java/org/apache/phoenix/end2end/OrphanChildLinkRowsIT.java: ########## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.end2end; + +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.HTable; +import org.apache.hadoop.hbase.client.Result; +import org.apache.hadoop.hbase.client.ResultScanner; +import org.apache.hadoop.hbase.client.Scan; +import org.apache.phoenix.coprocessor.tasks.ChildLinkScanTask; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.query.BaseTest; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.schema.PTable; +import org.apache.phoenix.schema.TableAlreadyExistsException; +import org.apache.phoenix.thirdparty.com.google.common.collect.Maps; +import org.apache.phoenix.util.EncodedColumnsUtil; +import org.apache.phoenix.util.PhoenixRuntime; +import org.apache.phoenix.util.ReadOnlyProps; +import org.apache.phoenix.util.SchemaUtil; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.ResultSet; +import java.util.Arrays; +import java.util.HashMap; +import java.util.Map; + +import static org.apache.phoenix.end2end.IndexRebuildTaskIT.waitForTaskState; +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.COLUMN_FAMILY; +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_CHILD_LINK_NAME; +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_CHILD_LINK_TABLE; +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.TABLE_NAME; +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.TABLE_SCHEM; +import static org.apache.phoenix.query.QueryConstants.VERIFIED_BYTES; + +@Category(NeedsOwnMiniClusterTest.class) +public class OrphanChildLinkRowsIT extends BaseTest { + + private static Map<String, String> expectedChildLinks = new HashMap<>(); + + @BeforeClass + public static synchronized void doSetup() throws Exception { + Map<String, String> props = Maps.newHashMapWithExpectedSize(1); + props.put(QueryServices.CHILD_LINK_ROW_AGE_THRESHOLD_TO_DELETE_MS_ATTRIB, "0"); + setUpTestDriver(new ReadOnlyProps(props.entrySet().iterator())); + + // Create 2 tables - T1 and T2. Create a view V1 on T1. + String t1 = "CREATE TABLE IF NOT EXISTS S1.T1 (TENANT_ID VARCHAR NOT NULL, A INTEGER NOT NULL, B INTEGER CONSTRAINT PK PRIMARY KEY (TENANT_ID, A))"; + String t2 = "CREATE TABLE IF NOT EXISTS S2.T2 (TENANT_ID VARCHAR NOT NULL, A INTEGER NOT NULL, B INTEGER CONSTRAINT PK PRIMARY KEY (TENANT_ID, A))"; + String v1 = "CREATE VIEW IF NOT EXISTS VS1.V1 (NEW_COL1 INTEGER, NEW_COL2 INTEGER) AS SELECT * FROM S1.T1 WHERE B > 10"; + + try (Connection connection = DriverManager.getConnection(getUrl())) { + connection.createStatement().execute(t1); + connection.createStatement().execute(t2); + connection.createStatement().execute(v1); + } + + expectedChildLinks.put("S1.T1", "VS1.V1"); + } + + /** + * 1. Disable the child link scan task. + * 2. Create a view (same name as existing view on T1) on T2. This CREATE VIEW will fail, verify if there was no orphan child link because of that. + * + * 3. Instrument CQSI to fail phase three of CREATE VIEW. Create a new view V2 on T2 (passes) and V1 on T2 which will fail. + * Both links T2->V2 and T2->V1 will be in UNVERIFIED state, repaired during read. + * Check if only 2 child links are returned: T2->V2 and T1->V1. + */ + @Test + public void testNoOrphanChildLinkRow() throws Exception { + + ConnectionQueryServicesTestImpl.setFailPhaseThreeChildLinkWriteForTesting(false); + ChildLinkScanTask.disableChildLinkScanTask(true); + + String v2 = "CREATE VIEW VS1.V1 (NEW_COL1 INTEGER, NEW_COL2 INTEGER) AS SELECT * FROM S2.T2 WHERE B > 10"; + + try (Connection connection = DriverManager.getConnection(getUrl())) { + connection.createStatement().execute(v2); + } + catch (TableAlreadyExistsException e) { + //expected since we are creating a view with the same name as an existing view + } + + verifyNoOrphanChildLinkRow(); + + // configure CQSI to fail the last write phase of CREATE VIEW + // where child link mutations are set to VERIFIED or are deleted + ConnectionQueryServicesTestImpl.setFailPhaseThreeChildLinkWriteForTesting(true); + String v3 = "CREATE VIEW IF NOT EXISTS VS2.V2 (NEW_COL1 INTEGER, NEW_COL2 INTEGER) AS SELECT * FROM S2.T2 WHERE B > 10"; + + try (Connection connection = DriverManager.getConnection(getUrl())) { + connection.createStatement().execute(v3); + connection.createStatement().execute(v2); Review Comment: Put an `assertFail()` after this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
