tkhurana commented on code in PR #1575:
URL: https://github.com/apache/phoenix/pull/1575#discussion_r1240087262
##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/tasks/ChildLinkScanTask.java:
##########
@@ -0,0 +1,58 @@
+package org.apache.phoenix.coprocessor.tasks;
+
+import org.apache.phoenix.coprocessor.TaskRegionObserver;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.schema.task.Task;
+import
org.apache.phoenix.thirdparty.com.google.common.annotations.VisibleForTesting;
+import org.apache.phoenix.util.QueryUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.ResultSet;
+
+/*
+Task to run a simple select * query on SYSTEM.CHILD_LINK table
+to trigger read repair and verify any unverified rows.
+ */
+public class ChildLinkScanTask extends BaseTask {
+
+ private static final Logger LOGGER =
LoggerFactory.getLogger(ChildLinkScanTask.class);
+ private static final String CHILD_LINK_QUERY = "SELECT COUNT(*) FROM
SYSTEM.CHILD_LINK";
+ private static boolean isDisabled = false;
+
+ @VisibleForTesting
+ public static void disableChildLinkScanTask(boolean disable) {
+ isDisabled = disable;
+ }
+
+ @Override
+ public TaskRegionObserver.TaskResult run(Task.TaskRecord taskRecord) {
+
+ if (isDisabled) {
+ return new
TaskRegionObserver.TaskResult(TaskRegionObserver.TaskResultCode.FAIL,
+ "ChildLinkScan task is disabled.");
+ }
+
+ int count = 0;
+ try {
+ PhoenixConnection pconn = QueryUtil.getConnectionOnServer(
+ env.getConfiguration()).unwrap(PhoenixConnection.class);
+ ResultSet rs =
pconn.createStatement().executeQuery(CHILD_LINK_QUERY);
+ rs.next();
Review Comment:
You should check the return value of rs.next()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
