[
https://issues.apache.org/jira/browse/PHOENIX-6910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744903#comment-17744903
]
ASF GitHub Bot commented on PHOENIX-6910:
-----------------------------------------
virajjasani commented on code in PR #1607:
URL: https://github.com/apache/phoenix/pull/1607#discussion_r1268973807
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java:
##########
@@ -155,6 +155,7 @@ public static Expression
pushKeyExpressionsToScan(StatementContext context, Set<
keySlots = whereClause.accept(visitor);
if (keySlots == null && (tenantId == null ||
!table.isMultiTenant()) && table.getViewIndexId() == null &&
!minOffset.isPresent()) {
+ // FIXME this overwrites salting info in the scanRange
Review Comment:
which query will be impacted due to the override?
##########
phoenix-core/src/main/java/org/apache/phoenix/iterate/ParallelScansCollector.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.iterate;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.phoenix.compile.QueryPlan;
+
+/**
+ * Stores some state to help build the parallel Scans structure
+ */
+public class ParallelScansCollector {
+
+ private ParallelScanGrouper grouper;
+ private boolean lastScanCrossedRegionBoundary = false;
+ private List<List<Scan>> parallelScans = new ArrayList<>();
+ private List<Scan> lastBatch = new ArrayList<>();
Review Comment:
nit: `grouper` and `parallelScans` both can be final
> Scans created during query compilation and execution against salted tables
> need to be more resilient
> ----------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6910
> URL: https://issues.apache.org/jira/browse/PHOENIX-6910
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.1.3
> Reporter: Jacob Isaac
> Assignee: Istvan Toth
> Priority: Major
> Attachments: 0001-PHOENIX-6910-initial-commit.patch,
> local-verify-run.gz
>
>
> The Scan objects created during where compilation and execution phases are
> incorrect when salted tables are involved and their regions have moved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
