[ 
https://issues.apache.org/jira/browse/PHOENIX-6910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745378#comment-17745378
 ] 

ASF GitHub Bot commented on PHOENIX-6910:
-----------------------------------------

virajjasani commented on code in PR #1607:
URL: https://github.com/apache/phoenix/pull/1607#discussion_r1270206801


##########
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java:
##########
@@ -155,6 +155,7 @@ public static Expression 
pushKeyExpressionsToScan(StatementContext context, Set<
             keySlots = whereClause.accept(visitor);
 
             if (keySlots == null && (tenantId == null || 
!table.isMultiTenant()) && table.getViewIndexId() == null && 
!minOffset.isPresent()) {
+                // FIXME this overwrites salting info in the scanRange

Review Comment:
   got it, sounds good





> Scans created during query compilation and execution against salted tables 
> need to be more resilient
> ----------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6910
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6910
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.1.3
>            Reporter: Jacob Isaac
>            Assignee: Istvan Toth
>            Priority: Major
>         Attachments: 0001-PHOENIX-6910-initial-commit.patch, 
> local-verify-run.gz
>
>
> The Scan objects created during where compilation and execution phases are 
> incorrect when salted tables are involved and their regions have moved. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to