[
https://issues.apache.org/jira/browse/PHOENIX-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755937#comment-17755937
]
ASF GitHub Bot commented on PHOENIX-6942:
-----------------------------------------
stoty commented on code in PR #1656:
URL: https://github.com/apache/phoenix/pull/1656#discussion_r1298360383
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexCoprocIT.java:
##########
@@ -58,12 +58,12 @@ public class IndexCoprocIT extends ParallelStatsDisabledIT {
"|org.apache.phoenix.index.GlobalIndexChecker|805306365|";
public static final String INDEX_REGION_OBSERVER_CONFIG =
"|org.apache.phoenix.hbase.index.IndexRegionObserver|805306366|" +
- "index.builder=org.apache.phoenix.index.PhoenixIndexBuilder," +
Review Comment:
index.builder and org.apache.hadoop.hbase.index.codec.class are present in
the HBase table descriptor.
For data backwards compatibility reasons I'd prefer not change these two
(even though they have the same problems as others).
i.e. Changing these would break older versions of Phoenix when trying to use
them if we changed these.
> Some config properties do not have phoenix prefix
> -------------------------------------------------
>
> Key: PHOENIX-6942
> URL: https://issues.apache.org/jira/browse/PHOENIX-6942
> Project: Phoenix
> Issue Type: Bug
> Reporter: Istvan Toth
> Assignee: Aron Attila Meszaros
> Priority: Minor
>
> Some config properties, like *index.verify.row.count.per.task*
> do not have the phoenix prefix.
> This breaks convention, and can potentially cause problems for users.
> Deprecate the old names, and add new names with the phoenix prefix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
