[
https://issues.apache.org/jira/browse/PHOENIX-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756682#comment-17756682
]
ASF GitHub Bot commented on PHOENIX-6942:
-----------------------------------------
stoty commented on code in PR #1656:
URL: https://github.com/apache/phoenix/pull/1656#discussion_r1299636488
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexCoprocIT.java:
##########
@@ -58,12 +58,12 @@ public class IndexCoprocIT extends ParallelStatsDisabledIT {
"|org.apache.phoenix.index.GlobalIndexChecker|805306365|";
public static final String INDEX_REGION_OBSERVER_CONFIG =
"|org.apache.phoenix.hbase.index.IndexRegionObserver|805306366|" +
- "index.builder=org.apache.phoenix.index.PhoenixIndexBuilder," +
Review Comment:
Can you revert the whitespace changes ?
If we don't change these, it's better to leave the file alone.
##########
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java:
##########
@@ -194,7 +194,6 @@ public BatchMutateContext(int clientVersion) {
.encodeVersion("0.94.9");
private static final int DEFAULT_ROWLOCK_WAIT_DURATION = 30000;
-
Review Comment:
nit: don't delete the empty line
##########
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -333,7 +330,6 @@ public int getMaxPendingRowCount() {
private static final int DEFAULT_ROWLOCK_WAIT_DURATION = 30000;
private static final int DEFAULT_CONCURRENT_MUTATION_WAIT_DURATION_IN_MS =
100;
-
Review Comment:
nit: don't delete the empty line
> Some config properties do not have phoenix prefix
> -------------------------------------------------
>
> Key: PHOENIX-6942
> URL: https://issues.apache.org/jira/browse/PHOENIX-6942
> Project: Phoenix
> Issue Type: Bug
> Reporter: Istvan Toth
> Assignee: Aron Attila Meszaros
> Priority: Minor
>
> Some config properties, like *index.verify.row.count.per.task*
> do not have the phoenix prefix.
> This breaks convention, and can potentially cause problems for users.
> Deprecate the old names, and add new names with the phoenix prefix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
