[
https://issues.apache.org/jira/browse/PHOENIX-7022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760054#comment-17760054
]
ASF GitHub Bot commented on PHOENIX-7022:
-----------------------------------------
lokiore commented on code in PR #1660:
URL: https://github.com/apache/phoenix/pull/1660#discussion_r1309138138
##########
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMultiInputUtil.java:
##########
@@ -31,19 +31,19 @@
import java.util.Properties;
+import static
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHOENIX_LEVEL_TTL_NOT_DEFINED;
import static
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME;
import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.TABLE_TYPE;
-import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHOENIX_TTL;
-import static
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHOENIX_TTL_NOT_DEFINED;
+import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.TTL;
import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.VIEW_TYPE;
public class PhoenixMultiInputUtil {
public static final String SELECT_ALL_VIEW_METADATA_FROM_SYSCAT_QUERY =
"SELECT TENANT_ID, TABLE_SCHEM, TABLE_NAME, PHOENIX_TTL FROM " +
Review Comment:
Thanks for finding this class is not being used so missed, will update.
> Add new columns TTL and ROW_KEY_PREFIX
> --------------------------------------
>
> Key: PHOENIX-7022
> URL: https://issues.apache.org/jira/browse/PHOENIX-7022
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Jacob Isaac
> Assignee: Lokesh Khurana
> Priority: Major
>
> When a view statement is defined by the constraints articulated in
> PHOENIX-4555, all rows created by the view will be prefixed by a KeyRange.
> The view thus can simply be represented by the prefixed KeyRange generated by
> the expression representing the view statement. In other words, there exists
> a one-to-one mapping between the view (defined by tenant, schema, tablename)
> and PREFIXED KeyRange.
> For lookup on the PREFIXED KeyRange we will create a new column
> ROW_KEY_PREFIX in SYSTEM.CATALOG. This new column will be populated during
> view creation when TTL is specified.
>
> The TTL column (INTEGER) will store the TTL when specified in line with the
> HBase spec (which uses an int). The PHOENIX_TTL-related columns and code will
> be deprecated in a separate jira.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
