[
https://issues.apache.org/jira/browse/PHOENIX-7022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765877#comment-17765877
]
ASF GitHub Bot commented on PHOENIX-7022:
-----------------------------------------
lokiore commented on code in PR #1660:
URL: https://github.com/apache/phoenix/pull/1660#discussion_r1327863767
##########
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -5480,21 +5522,21 @@ private boolean evaluateStmtProperties(MetaProperties
metaProperties, MetaProper
}
}
- if (metaProperties.getPhoenixTTL() != null) {
+ if (metaProperties.getTTL() != null) {
if (table.getType() == PTableType.INDEX) {
throw new SQLExceptionInfo.Builder(
SQLExceptionCode.CANNOT_SET_OR_ALTER_PROPERTY_FOR_INDEX)
.build()
.buildException();
}
- if (table.getType() != PTableType.TABLE && table.getType() !=
SYSTEM) {
+ if (table.getType() != PTableType.TABLE) {
Review Comment:
Yes, for SYSTEM table TTL is not supported at Phoenix level as discussed I
am not sure why this change is shown by git as this is already there :-
https://github.com/apache/phoenix/blame/40a30ac66a7655003f52e816525c3e209d44a083/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java#L2065
> Add new columns TTL and ROW_KEY_PREFIX
> --------------------------------------
>
> Key: PHOENIX-7022
> URL: https://issues.apache.org/jira/browse/PHOENIX-7022
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Jacob Isaac
> Assignee: Lokesh Khurana
> Priority: Major
>
> When a view statement is defined by the constraints articulated in
> PHOENIX-4555, all rows created by the view will be prefixed by a KeyRange.
> The view thus can simply be represented by the prefixed KeyRange generated by
> the expression representing the view statement. In other words, there exists
> a one-to-one mapping between the view (defined by tenant, schema, tablename)
> and PREFIXED KeyRange.
> For lookup on the PREFIXED KeyRange we will create a new column
> ROW_KEY_PREFIX in SYSTEM.CATALOG. This new column will be populated during
> view creation when TTL is specified.
>
> The TTL column (INTEGER) will store the TTL when specified in line with the
> HBase spec (which uses an int). The PHOENIX_TTL-related columns and code will
> be deprecated in a separate jira.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
