[
https://issues.apache.org/jira/browse/PHOENIX-7029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760571#comment-17760571
]
ASF GitHub Bot commented on PHOENIX-7029:
-----------------------------------------
palashc commented on code in PR #1664:
URL: https://github.com/apache/phoenix/pull/1664#discussion_r1310657513
##########
phoenix-core/src/test/java/org/apache/phoenix/jdbc/PhoenixTestDriver.java:
##########
Review Comment:
@jpisaac FYI
> Add support for multiple query services in PhoenixTestDriver.
> -------------------------------------------------------------
>
> Key: PHOENIX-7029
> URL: https://issues.apache.org/jira/browse/PHOENIX-7029
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rushabh Shah
> Assignee: Palash Chauhan
> Priority: Major
>
> In PhoenixTestDriver, we cache the connectionQueryServices at class level and
> use it for all the requests.
>
> {code:java}
> @Override // public for testing
> public synchronized ConnectionQueryServices getConnectionQueryServices(String
> url, Properties info) throws SQLException {
> checkClosed();
> if (connectionQueryServices != null) {
> return connectionQueryServices;
> }
> ....
> ....{code}
> In PHOENIX-7025, we want to test different clients using different CQSI. We
> need to add support in PhoenixTestDriver to hold multiple CQSI.
> Even though we are committing the sub tasks to dev branch, this change is
> independent of the feature and can go in master branch directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
