[
https://issues.apache.org/jira/browse/PHOENIX-7029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760623#comment-17760623
]
ASF GitHub Bot commented on PHOENIX-7029:
-----------------------------------------
shahrs87 commented on code in PR #1664:
URL: https://github.com/apache/phoenix/pull/1664#discussion_r1310805918
##########
phoenix-core/src/it/java/org/apache/phoenix/jdbc/PhoenixTestDriverIT.java:
##########
@@ -31,13 +49,48 @@ public static synchronized void doSetup() throws Exception {
setUpTestDriver(new ReadOnlyProps(props.entrySet().iterator()));
}
+ /**
+ * Test that connections created using the same url have the same CQSI
object.
+ */
+ @Test
+ public void testSameCQSI() throws SQLException {
+ Properties props = PropertiesUtil.deepCopy(TestUtil.TEST_PROPERTIES);
+ String url = QueryUtil.getConnectionUrl(props, config, "client1");
+ try (Connection conn1 = DriverManager.getConnection(url);
+ Connection conn2 = DriverManager.getConnection(url)) {
+ ConnectionQueryServices cqs1 =
conn1.unwrap(PhoenixConnection.class).getQueryServices();
+ ConnectionQueryServices cqs2 =
conn2.unwrap(PhoenixConnection.class).getQueryServices();
+ Assert.assertNotNull(cqs1);
+ Assert.assertNotNull(cqs2);
+ Assert.assertTrue("Connections using the same URL should have the
same CQSI object.", cqs1.equals(cqs2));
Review Comment:
You could have used assertEquals.
> Add support for multiple query services in PhoenixTestDriver.
> -------------------------------------------------------------
>
> Key: PHOENIX-7029
> URL: https://issues.apache.org/jira/browse/PHOENIX-7029
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rushabh Shah
> Assignee: Palash Chauhan
> Priority: Major
>
> In PhoenixTestDriver, we cache the connectionQueryServices at class level and
> use it for all the requests.
>
> {code:java}
> @Override // public for testing
> public synchronized ConnectionQueryServices getConnectionQueryServices(String
> url, Properties info) throws SQLException {
> checkClosed();
> if (connectionQueryServices != null) {
> return connectionQueryServices;
> }
> ....
> ....{code}
> In PHOENIX-7025, we want to test different clients using different CQSI. We
> need to add support in PhoenixTestDriver to hold multiple CQSI.
> Even though we are committing the sub tasks to dev branch, this change is
> independent of the feature and can go in master branch directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
