stoty commented on PR #1665: URL: https://github.com/apache/phoenix/pull/1665#issuecomment-1708144872
> 1. I've checked oracle 23c version, strangely, it seems that it has the same faulty behavior, so the `columnLabel` and the `columnName` are the same in `ResultSetMetaData`. On the other hand, jdbc docs states: > > > getColumnLabel: Gets the designated column's suggested title for use in printouts and displays. The suggested title is usually specified by the SQL AS clause. If a SQL AS is not specified, the value returned from getColumnLabel will be the same as the value returned by the getColumnName method. > > 2. We discussed offline the upper/lowercase escaping problem, and come to the conclusion to not include `"` in the returned String to have the same behavior as before. > 3. Test failures were caused by using cfamily wildcards ( `SELECT cf.*`), where the previous implementation returned the column name for both `getColumnLabel` and `getColumnName` (without `cf.`). With this change, `getColumnLabel` returns just the column name as before, but `getColumnName` returns the column family as well (see `QueryCompilerTest.java`). @stoty What do you think, what would be the correct behavior in this case? I think that the patch's behaviour is fine, and follows the standard as much as possible. We couldn't find the reason for removing the CF from the Label, but as this is the previous behaviour, and there is a comment in the code that confirms that this was the intended behaviour, we have left it as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
