stoty commented on code in PR #1665:
URL: https://github.com/apache/phoenix/pull/1665#discussion_r1325408095
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ColumnProjector.java:
##########
@@ -36,11 +36,17 @@
*/
public interface ColumnProjector {
/**
- * Get the column name as it was referenced in the query
Review Comment:
Changing the semantics for getName() makes sense.
My concerns are:
- Does connectors or PQS refer it , and if yes is that a pronlem?
- Does this have backwards compatibility implications ?
My gut feeling is that it's never used outside the client context, but I
will check this.
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionProjector.java:
##########
@@ -24,29 +24,31 @@
import org.apache.phoenix.expression.Expression;
import org.apache.phoenix.schema.types.PDataType;
import org.apache.phoenix.schema.tuple.Tuple;
-
+import org.apache.phoenix.util.SchemaUtil;
Review Comment:
This is not used, please remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
