[
https://issues.apache.org/jira/browse/PHOENIX-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765007#comment-17765007
]
ASF GitHub Bot commented on PHOENIX-6920:
-----------------------------------------
stoty commented on code in PR #1665:
URL: https://github.com/apache/phoenix/pull/1665#discussion_r1325408095
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ColumnProjector.java:
##########
@@ -36,11 +36,17 @@
*/
public interface ColumnProjector {
/**
- * Get the column name as it was referenced in the query
Review Comment:
Changing the semantics for getName() makes sense.
My concerns are:
- Does connectors or PQS refer it , and if yes is that a pronlem?
- Does this have backwards compatibility implications ?
My gut feeling is that it's never used outside the client context, but I
will check this.
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionProjector.java:
##########
@@ -24,29 +24,31 @@
import org.apache.phoenix.expression.Expression;
import org.apache.phoenix.schema.types.PDataType;
import org.apache.phoenix.schema.tuple.Tuple;
-
+import org.apache.phoenix.util.SchemaUtil;
Review Comment:
This is not used, please remove.
> PQS / thin client doesn't distinguish between label and column_name
> -------------------------------------------------------------------
>
> Key: PHOENIX-6920
> URL: https://issues.apache.org/jira/browse/PHOENIX-6920
> Project: Phoenix
> Issue Type: Bug
> Components: queryserver
> Reporter: Istvan Toth
> Assignee: Aron Attila Meszaros
> Priority: Major
>
> While debugging PHOENIX-6917, I found that we receive the aliased column name
> in both the _column_name_ and _label_ fields of the column metadata in
> protobuf.
> This happened with PQS head and Phoenix 5.2.0-SNAPSHOT.
> Apparently, some older version used to work correctly (and returned the
> unaliased name in {_}column_name{_})
> We need to check if this is a Phoenix or Avatica regression first, then fix
> it in the appropriate project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
