[ 
https://issues.apache.org/jira/browse/PHOENIX-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765013#comment-17765013
 ] 

ASF GitHub Bot commented on PHOENIX-6920:
-----------------------------------------

stoty commented on code in PR #1665:
URL: https://github.com/apache/phoenix/pull/1665#discussion_r1325413783


##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ColumnProjector.java:
##########
@@ -36,11 +36,17 @@
  */
 public interface ColumnProjector {
     /**
-     * Get the column name as it was referenced in the query

Review Comment:
   PQS and Connectors do not refer this class.



##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ColumnProjector.java:
##########
@@ -36,11 +36,17 @@
  */
 public interface ColumnProjector {
     /**
-     * Get the column name as it was referenced in the query

Review Comment:
   We don't serialize ColumnProjectors, so we're good wrt backwards 
compatibility as well.





> PQS / thin client doesn't distinguish between label and column_name
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-6920
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6920
>             Project: Phoenix
>          Issue Type: Bug
>          Components: queryserver
>            Reporter: Istvan Toth
>            Assignee: Aron Attila Meszaros
>            Priority: Major
>
> While debugging PHOENIX-6917, I found that we receive the aliased column name 
> in both the _column_name_ and _label_ fields of the column metadata in 
> protobuf.
> This happened with PQS head and Phoenix 5.2.0-SNAPSHOT.
> Apparently, some older version used to work correctly (and returned the 
> unaliased name in {_}column_name{_})
> We need to check if this is a Phoenix or Avatica regression first, then fix 
> it in the appropriate project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to