[
https://issues.apache.org/jira/browse/PHOENIX-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765855#comment-17765855
]
ASF GitHub Bot commented on PHOENIX-7025:
-----------------------------------------
tkhurana commented on code in PR #1666:
URL: https://github.com/apache/phoenix/pull/1666#discussion_r1327797302
##########
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java:
##########
@@ -417,11 +508,20 @@ private PhoenixResultSet executeQuery(final
CompilableStatement stmt,
e.getSchemaName(),
e.getTableName(), true)
.wasUpdated()) {
//TODO we can log retry count and
error for debugging in LOG table
- return executeQuery(stmt, false,
queryLogger, noCommit);
+ return executeQuery(stmt, false,
queryLogger, noCommit, validateLastDdlTimestamp);
}
}
throw e;
- } catch (RuntimeException e) {
+ } catch (StaleMetadataCacheException e) {
Review Comment:
I think you need to move this catch block inside where you are calling
validateTimestamp otherwise the finally block will be executed twice when
StaleMetadataCacheException is raised.
> Create a new RPC to validate last ddl timestamp for read requests.
> ------------------------------------------------------------------
>
> Key: PHOENIX-7025
> URL: https://issues.apache.org/jira/browse/PHOENIX-7025
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rushabh Shah
> Assignee: Palash Chauhan
> Priority: Major
>
> Introduce a new RPC request from phoenix client to any region server via
> PhoenixRegionServerEndpoint#validateLastDDLTimestamp. Since the last ddl
> timestamp cache is maintained by all the regionservers, you can choose any
> regionserver randomly. In future, we can make this rpc more resilient by
> sending this rpc to multiple regionservers simultaneously.
> If phoenix client throws StaleMetadataCacheException then invalidate the
> cache on the client side and retry executeQuery method while fetching the
> updated metadata from SYSCAT regionserver.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
