tkhurana commented on code in PR #1667:
URL: https://github.com/apache/phoenix/pull/1667#discussion_r1330809897
##########
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java:
##########
@@ -94,6 +94,21 @@ public boolean isBytesComparableWith(PDataType otherType) {
return equalsAny(this, otherType, PVarbinary.INSTANCE,
PBinary.INSTANCE);
}
+ /**
+ * @return true if {@link PDataType} can be declared as primary key
otherwise false.
+ */
+ public boolean canBePrimaryKey() {
+ return true;
+ }
+
+ /**
+ * @return true if {@link PDataType} supports equality operators
(=,!=,<,>,<=,>=) otherwise
+ * false.
+ */
+ public boolean isEqualitySupported() {
Review Comment:
Maybe rename this function to `isComparisonSupported`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
