tkhurana commented on code in PR #1667:
URL: https://github.com/apache/phoenix/pull/1667#discussion_r1330810257
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java:
##########
@@ -202,6 +202,18 @@ public Expression visitLeave(ComparisonParseNode node,
List<Expression> children
ParseNode rhsNode = node.getChildren().get(1);
Expression lhsExpr = children.get(0);
Expression rhsExpr = children.get(1);
+
+ PDataType dataTypeOfLHSExpr = lhsExpr.getDataType();
+ if (dataTypeOfLHSExpr != null &&
!dataTypeOfLHSExpr.isEqualitySupported()) {
Review Comment:
IsComparisonSuported sounds a better name in my opinion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
