jpisaac commented on code in PR #1689:
URL: https://github.com/apache/phoenix/pull/1689#discussion_r1336580669
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java:
##########
@@ -412,7 +412,9 @@ public Expression visit(ColumnParseNode node) throws
SQLException {
// If the column is matched in a WHERE clause against a constant not
equal to it's constant, then the entire
// query would become degenerate.
if (!resolveViewConstants && IndexUtil.getViewConstantValue(column,
ptr)) {
- return
LiteralExpression.newConstant(column.getDataType().toObject(ptr),
column.getDataType());
+ return LiteralExpression.newConstant(
Review Comment:
The toObject is used to store the value object and the third parameter is
used to invert the object value to its byte representation in the
LiteralExpression class. Both value and bytevalue are used in LiteralExpression
class for different reasons.
Maybe need to do some due diligence - that it is not getting inverted twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
