virajjasani commented on code in PR #1689:
URL: https://github.com/apache/phoenix/pull/1689#discussion_r1338001372
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java:
##########
@@ -412,7 +412,9 @@ public Expression visit(ColumnParseNode node) throws
SQLException {
// If the column is matched in a WHERE clause against a constant not
equal to it's constant, then the entire
// query would become degenerate.
if (!resolveViewConstants && IndexUtil.getViewConstantValue(column,
ptr)) {
- return
LiteralExpression.newConstant(column.getDataType().toObject(ptr),
column.getDataType());
+ return LiteralExpression.newConstant(
Review Comment:
Exactly, it seems we might not need 2nd argument, 1st one should be
sufficient to avoid double invert. Let me confirm that first.
Thanks @ranganathg @jpisaac !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
