[
https://issues.apache.org/jira/browse/PHOENIX-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770012#comment-17770012
]
ASF GitHub Bot commented on PHOENIX-7008:
-----------------------------------------
haridsv commented on code in PR #1681:
URL: https://github.com/apache/phoenix/pull/1681#discussion_r1339989347
##########
bin/sqlline.py:
##########
@@ -123,8 +126,11 @@ def kill_child():
'" -Dlog4j2.configurationFile=file:' +
os.path.join(phoenix_utils.current_dir, "log4j2.properties") + \
disable_jna + \
" sqlline.SqlLine -d org.apache.phoenix.jdbc.PhoenixDriver" + \
- " -u jdbc:phoenix:" + phoenix_utils.shell_quote([zookeeper]) + \
- " -n none -p none --color=" + colorSetting + " --fastConnect=" +
tryDecode(args.fastconnect) + \
- " --verbose=" + tryDecode(args.verbose) + " --incremental=false
--isolation=TRANSACTION_READ_COMMITTED " + sqlfile
+ (not args.noconnect and " -u jdbc:phoenix:" +
phoenix_utils.shell_quote([zookeeper]) or "") + \
Review Comment:
I now moved the change into
[PHOENIX-7055](https://issues.apache.org/jira/browse/PHOENIX-7055) and created
a separate PR #1695. Please take a look.
> CDC DDL Compiler
> ----------------
>
> Key: PHOENIX-7008
> URL: https://issues.apache.org/jira/browse/PHOENIX-7008
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Hari Krishna Dara
> Priority: Major
>
> The purpose of this sub-task is to provide DDL query capability for CDC
> (Change Data Capture) feature.
> The CREATE CDC table query can look something like:
> {code:java}
> Create CDC <CDC Table Name> on <Data Table Name> (PHOENIX_ROW_TIMESTAMP() |
> <Data Table Column>) INCLUDE (pre | post | latest | all) TTL = <Age in
> seconds> INDEX = <GLOBAL | LOCAL> SALT_BUCKETS=<salt bucket count> {code}
>
> The changes include:
> * Create new table type CDC in SYSTEM.CATALOG
> * Provide CDC table to data table link in SYSTEM.CATALOG
> * Query parser/grammer changes
> * PTable link type: CDC_TABLE (from CDC table to data table)
> * MetaDataClient and ConnectionQueryServicesImpl (CQSI) changes to ensure no
> physical table gets created for CDC, it is rather treated as virtual table
> * Create Uncovered global index on data table using either
> PHOENIX_ROW_TIMESTAMP() or a data table column (as provided in the query)
> * Store INCLUDE image values (pre/post/latest/all) as CDC virtual table
> property in SYSTEM.CATALOG
> * ALTER CDC query should be able to update any CDC attributes
>
> ALTER and DROP CDC queries are provided by PHOENIX-7054.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
