[
https://issues.apache.org/jira/browse/PHOENIX-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770349#comment-17770349
]
ASF GitHub Bot commented on PHOENIX-7008:
-----------------------------------------
haridsv commented on code in PR #1681:
URL: https://github.com/apache/phoenix/pull/1681#discussion_r1341121209
##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -4107,6 +4109,9 @@ protected PhoenixConnection
upgradeSystemCatalogIfRequired(PhoenixConnection met
metaConnection = addColumnsIfNotExists(metaConnection,
PhoenixDatabaseMetaData.SYSTEM_CATALOG,
MIN_SYSTEM_TABLE_TIMESTAMP_5_2_0,
Review Comment:
The tests are still failing for the same reason, but this time on the
`PHYSICAL_TABLE_NAME` column (the very first one). Could you please check to
see what I might have done wrong?
> CDC DDL Compiler
> ----------------
>
> Key: PHOENIX-7008
> URL: https://issues.apache.org/jira/browse/PHOENIX-7008
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Hari Krishna Dara
> Priority: Major
>
> The purpose of this sub-task is to provide DDL query capability for CDC
> (Change Data Capture) feature.
> The CREATE CDC table query can look something like:
> {code:java}
> Create CDC <CDC Table Name> on <Data Table Name> (PHOENIX_ROW_TIMESTAMP() |
> <Data Table Column>) INCLUDE (pre | post | latest | all) TTL = <Age in
> seconds> INDEX = <GLOBAL | LOCAL> SALT_BUCKETS=<salt bucket count> {code}
>
> The changes include:
> * Create new table type CDC in SYSTEM.CATALOG
> * Provide CDC table to data table link in SYSTEM.CATALOG
> * Query parser/grammer changes
> * PTable link type: CDC_TABLE (from CDC table to data table)
> * MetaDataClient and ConnectionQueryServicesImpl (CQSI) changes to ensure no
> physical table gets created for CDC, it is rather treated as virtual table
> * Create Uncovered global index on data table using either
> PHOENIX_ROW_TIMESTAMP() or a data table column (as provided in the query)
> * Store INCLUDE image values (pre/post/latest/all) as CDC virtual table
> property in SYSTEM.CATALOG
> * ALTER CDC query should be able to update any CDC attributes
>
> ALTER and DROP CDC queries are provided by PHOENIX-7054.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
