palashc commented on code in PR #1666:
URL: https://github.com/apache/phoenix/pull/1666#discussion_r1342998688
##########
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -903,7 +903,7 @@ private boolean
addColumnsAndIndexesFromAncestors(MetaDataMutationResult result,
String parentSchemaName =
SchemaUtil.getSchemaNameFromFullName(parentName);
tableName = SchemaUtil.getTableNameFromFullName(parentName);
MetaDataMutationResult parentResult =
updateCache(connection.getTenantId(), parentSchemaName, tableName,
- false, resolvedTimestamp);
+ true, resolvedTimestamp);
Review Comment:
I think to avoid any side effects, it will be better to pass the
`alwaysHitServer` value to `addColumnsAndIndexesFromAncestors` instead of just
setting it to true always. I will make that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
