[
https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771473#comment-17771473
]
ASF GitHub Bot commented on PHOENIX-6053:
-----------------------------------------
Aarchy commented on code in PR #1690:
URL: https://github.com/apache/phoenix/pull/1690#discussion_r1344074981
##########
phoenix-core/src/main/java/org/apache/phoenix/util/ClientUtil.java:
##########
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.util;
+
+import java.io.IOException;
+import java.sql.SQLException;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.apache.hadoop.hbase.DoNotRetryIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NotServingRegionException;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException;
+import org.apache.phoenix.coprocessor.HashJoinCacheNotFoundException;
+import org.apache.phoenix.exception.PhoenixIOException;
+import org.apache.phoenix.exception.SQLExceptionCode;
+import org.apache.phoenix.exception.SQLExceptionInfo;
+import org.apache.phoenix.schema.StaleRegionBoundaryCacheException;
+
+public class ClientUtil {
Review Comment:
Checked these, if I'm correct, there are 3 of these kind of splits:
- ClientUtil - ServerUtil: Here the original class was ServerUtil, so using
ClientUtil on the client side is ok IMO.
- Task - ServerTask and ViewUtil - ServerViewUtil: They are similar, there
is inheritance between these classes, Server versions are the more specified
classes and the name represents this (also they are less used)
> Use shaded hadoop-client and hbase-shaded-client in phoenix-client
> ------------------------------------------------------------------
>
> Key: PHOENIX-6053
> URL: https://issues.apache.org/jira/browse/PHOENIX-6053
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.1.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Attachments: Phoenix_separation.pdf
>
>
> The phoenix client is built with the unshaded Hadoop and HBase dependencies,
> and then relocates some (a lot) of those to declutter the client classpath.
> Try to use hadoop-client and hbase-shaded-client-byo-hadoop instead. (And
> keep relocating our direct dependecies)
> While this will likely further bloat the thick client JAR, it shouldÂ
> * clean up the classpath further
> * Would decouple most of the dependencies that Phoenix shares with
> Hbase/Hadoop from them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
