[
https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771789#comment-17771789
]
ASF GitHub Bot commented on PHOENIX-6053:
-----------------------------------------
Aarchy commented on code in PR #1690:
URL: https://github.com/apache/phoenix/pull/1690#discussion_r1345523667
##########
phoenix-coprocessors/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:
##########
@@ -612,15 +485,9 @@ public void
setScanOptionsForFlushesAndCompactionsWhenPhoenixTTLIsDisabled(Confi
options.setMinVersions(getMinVersions(options, cfDescriptor));
}
- public static long getMaxLookbackInMillis(Configuration conf){
- //config param is in seconds, switch to millis
- return conf.getLong(PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,
- DEFAULT_PHOENIX_MAX_LOOKBACK_AGE) * 1000;
- }
-
public static boolean isMaxLookbackTimeEnabled(Configuration conf){
- return
isMaxLookbackTimeEnabled(conf.getLong(PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,
Review Comment:
I think this class (and also the function) is moved to coprocessors package
> Use shaded hadoop-client and hbase-shaded-client in phoenix-client
> ------------------------------------------------------------------
>
> Key: PHOENIX-6053
> URL: https://issues.apache.org/jira/browse/PHOENIX-6053
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.1.0
> Reporter: Istvan Toth
> Assignee: Aron Attila Meszaros
> Priority: Major
> Attachments: Phoenix_separation.pdf
>
>
> The phoenix client is built with the unshaded Hadoop and HBase dependencies,
> and then relocates some (a lot) of those to declutter the client classpath.
> Try to use hadoop-client and hbase-shaded-client-byo-hadoop instead. (And
> keep relocating our direct dependecies)
> While this will likely further bloat the thick client JAR, it shouldÂ
> * clean up the classpath further
> * Would decouple most of the dependencies that Phoenix shares with
> Hbase/Hadoop from them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
