Aarchy commented on code in PR #1690:
URL: https://github.com/apache/phoenix/pull/1690#discussion_r1345523667
##########
phoenix-coprocessors/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:
##########
@@ -612,15 +485,9 @@ public void
setScanOptionsForFlushesAndCompactionsWhenPhoenixTTLIsDisabled(Confi
options.setMinVersions(getMinVersions(options, cfDescriptor));
}
- public static long getMaxLookbackInMillis(Configuration conf){
- //config param is in seconds, switch to millis
- return conf.getLong(PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,
- DEFAULT_PHOENIX_MAX_LOOKBACK_AGE) * 1000;
- }
-
public static boolean isMaxLookbackTimeEnabled(Configuration conf){
- return
isMaxLookbackTimeEnabled(conf.getLong(PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,
Review Comment:
I think this class (and also the function) is moved to coprocessors package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
