Aarchy commented on code in PR #1690:
URL: https://github.com/apache/phoenix/pull/1690#discussion_r1411855582
##########
phoenix-coprocessors/src/main/java/org/apache/phoenix/coprocessor/UncoveredIndexRegionScanner.java:
##########
@@ -321,10 +324,12 @@ private boolean getNextCoveredIndexRow(List<Cell> result)
throws IOException {
}
} else {
if (indexMaintainer.isUncovered()) {
+ long ts = indexRow.get(0).getTimestamp();
// Since we also scan the empty column for uncovered
global indexes, this mean the data row
// does not exist. Delete the index row if the index
is an uncovered global index
- indexMaintainer.deleteRowIfAgedEnough(indexRowKey,
indexRow.get(0).getTimestamp(),
- ageThreshold, false, region);
+ if (indexMaintainer.isAgedEnough(ts, ageThreshold)) {
+
region.delete(indexMaintainer.createDelete(indexRowKey, ts, false));
Review Comment:
According to hbase documentation:
batchMutate: Perform a batch of mutations. Note this supports only Put and
Delete mutations and will ignore other types passed.
delete: Deletes the specified cells/row.
In this specific case the batch contained only 1 delete, so changing it to a
single delete operation should do the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
