jpisaac commented on code in PR #1706:
URL: https://github.com/apache/phoenix/pull/1706#discussion_r1357435647
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices
services, ConnectionInfo in
@Override
public void addConnection(PhoenixConnection connection) throws
SQLException {
+ super.addConnection(connection);
connections.add(connection);
super.addConnection(connection);
}
@Override
public void removeConnection(PhoenixConnection connection) throws
SQLException {
+ super.removeConnection(connection);
Review Comment:
Same here
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices
services, ConnectionInfo in
@Override
public void addConnection(PhoenixConnection connection) throws
SQLException {
+ super.addConnection(connection);
Review Comment:
Was this added intentionally? Do see a similar statement below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
