lokiore commented on code in PR #1706:
URL: https://github.com/apache/phoenix/pull/1706#discussion_r1357457963
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices
services, ConnectionInfo in
@Override
public void addConnection(PhoenixConnection connection) throws
SQLException {
+ super.addConnection(connection);
Review Comment:
Yes, We are testing connection counts for different scenarios in
LoggingConnectionLimiterIT, and these counts gets updated when we call acquire
connection in CQSI's addConnection, which was not being used before as part of
CQSTestImpl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
