mihir6692 commented on PR #1682: URL: https://github.com/apache/phoenix/pull/1682#issuecomment-1783251091
> My main concern is this is too sfdc focused. A conection profile doesn't exist within the concept space of phoenix. I'd rebrand this as ConnectionInfo metrics. That's right. I have changed it to ConnecitonQueryService Metrics since this metrics are calculated at CQS Level. > My second concern is there apears to be a bunch of copy pasted or similar code... I opened a Jira for a better overall metrics infrastrucutre and while that is out of scope is it possiblegenericfy some of this. That's right there are multiple class/code blocks which are copy pasted. I will add notes of these [PHOENIX-6174](https://issues.apache.org/jira/browse/PHOENIX-6174) to simplify in future. @dbwong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
