mihir6692 commented on PR #1682: URL: https://github.com/apache/phoenix/pull/1682#issuecomment-1783400093
> I am in general very wary of overriding HBase properties from a Phoenix application, as this can very easily lead to failures for properties that must be in sync across the cluster for HBase to work. > > In my ideal world we'd have some kind of whitelist for properties that are known to be safe to override (or an inverse blacklist) > (Of course users could still wreak havoc by modifying the hbase-site.xml used by the client) > > I would tie the id propagation part to https://issues.apache.org/jira/browse/PHOENIX-5974. > We could either correlate that single ID with the ConnectionInfo/profile (though it requires extra bookeepeing), or just add it alongside the query id. QUERY_SERVICE_NAME config property is only for Phoenix Connection and for metrics related to CSQI. It won't be used anywhere in HBase layer. As far as I understand, [PHOENIX-5974](https://issues.apache.org/jira/browse/PHOENIX-5974) is different from this JIRA and having a default name for CQSI Object. @stoty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
