chaijunjie0101 commented on code in PR #1728:
URL: https://github.com/apache/phoenix/pull/1728#discussion_r1377100037
##########
phoenix-core/src/main/java/org/apache/phoenix/execute/HashJoinPlan.java:
##########
@@ -462,7 +462,9 @@ public ServerCache execute(HashJoinPlan parent) throws
SQLException {
}
Object result = expectSingleRow ? (values.isEmpty() ? null :
values.get(0)) : PArrayDataType.instantiatePhoenixArray(baseType,
values.toArray());
- parent.getContext().setSubqueryResult(select, result);
+ if (result != null) {
Review Comment:
thanks for reviewing
for the org.apache.phoenix.execute.HashJoinPlan.WhereClauseSubPlan#execute,
it always return null;
you mean change here like this?
if (result == null) {
return null;
}
parent.getContext().setSubqueryResult(select, result);
return null;
here i changed just judge to avoid put a null value to subqueryResults as a
subquery result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
