stoty commented on code in PR #1728:
URL: https://github.com/apache/phoenix/pull/1728#discussion_r1377136100
##########
phoenix-core/src/main/java/org/apache/phoenix/execute/HashJoinPlan.java:
##########
@@ -462,7 +462,9 @@ public ServerCache execute(HashJoinPlan parent) throws
SQLException {
}
Object result = expectSingleRow ? (values.isEmpty() ? null :
values.get(0)) : PArrayDataType.instantiatePhoenixArray(baseType,
values.toArray());
- parent.getContext().setSubqueryResult(select, result);
+ if (result != null) {
Review Comment:
Forget it, your code is fine.
We always have to return null anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
