[
https://issues.apache.org/jira/browse/PHOENIX-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782024#comment-17782024
]
ASF GitHub Bot commented on PHOENIX-7091:
-----------------------------------------
stoty commented on code in PR #140:
URL:
https://github.com/apache/phoenix-queryserver/pull/140#discussion_r1379685795
##########
pom.xml:
##########
@@ -815,23 +973,19 @@
<artifactId>hadoop-minikdc</artifactId>
<version>${hadoop.version}</version>
<scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
<groupId>bouncycastle</groupId>
<artifactId>bcprov-jdk15</artifactId>
<version>140</version>
<scope>test</scope>
</dependency>
- <dependency>
Review Comment:
So these were duplicated.
##########
pom.xml:
##########
@@ -370,6 +370,49 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>banned-commons-logging</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <bannedDependencies>
+ <excludes>
+
<exclude>commons-logging:commons-logging</exclude>
+ </excludes>
+ <message>We don't use commons-logging
any more, so do not depend on it directly.</message>
+
<searchTransitive>false</searchTransitive>
+ </bannedDependencies>
+ </rules>
+ </configuration>
+ </execution>
+ <execution>
+ <id>banned-other-logging-framework</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <bannedDependencies>
+ <excludes>
+ <exclude>log4j:*</exclude>
Review Comment:
Do we even need to allow log4j2 ?
Isn't all logging happening via slf4j ?
> Cleanup and ban log4j and related jars from phoenix-query-server
> ----------------------------------------------------------------
>
> Key: PHOENIX-7091
> URL: https://issues.apache.org/jira/browse/PHOENIX-7091
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Nihal Jain
> Assignee: Nihal Jain
> Priority: Major
>
> PQS has moved to log4j2 in
> [PHOENIX-6931|https://github.com/apache/phoenix-queryserver/pull/130] but
> there are still traces of other logging framework jars in the build. This
> task is to delete all traces of such logging from build and also explicitly
> ban them from coming back again in future via maven-enforcer-plugin
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
