[
https://issues.apache.org/jira/browse/PHOENIX-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782285#comment-17782285
]
ASF GitHub Bot commented on PHOENIX-7091:
-----------------------------------------
NihalJain commented on code in PR #140:
URL:
https://github.com/apache/phoenix-queryserver/pull/140#discussion_r1380617528
##########
pom.xml:
##########
@@ -815,23 +973,19 @@
<artifactId>hadoop-minikdc</artifactId>
<version>${hadoop.version}</version>
<scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
<groupId>bouncycastle</groupId>
<artifactId>bcprov-jdk15</artifactId>
<version>140</version>
<scope>test</scope>
</dependency>
- <dependency>
Review Comment:
right!
> Cleanup and ban log4j and related jars from phoenix-query-server
> ----------------------------------------------------------------
>
> Key: PHOENIX-7091
> URL: https://issues.apache.org/jira/browse/PHOENIX-7091
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Nihal Jain
> Assignee: Nihal Jain
> Priority: Major
>
> PQS has moved to log4j2 in
> [PHOENIX-6931|https://github.com/apache/phoenix-queryserver/pull/130] but
> there are still traces of other logging framework jars in the build. This
> task is to delete all traces of such logging from build and also explicitly
> ban them from coming back again in future via maven-enforcer-plugin
--
This message was sent by Atlassian Jira
(v8.20.10#820010)