[
https://issues.apache.org/jira/browse/PHOENIX-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792236#comment-17792236
]
ASF GitHub Bot commented on PHOENIX-7040:
-----------------------------------------
jpisaac commented on code in PR #1710:
URL: https://github.com/apache/phoenix/pull/1710#discussion_r1412637207
##########
phoenix-core/src/main/java/org/apache/phoenix/util/ViewUtil.java:
##########
@@ -132,20 +134,35 @@ public static Pair<List<PTable>, List<TableInfo>>
findAllDescendantViews(
List<PTable> legitimateChildViews = new ArrayList<>();
List<TableInfo> orphanChildViews = new ArrayList<>();
- findAllDescendantViews(sysCatOrsysChildLink, serverSideConfig,
tenantId, schemaName,
+ return findAllDescendantViews(sysCatOrsysChildLink, serverSideConfig,
tenantId, schemaName,
tableOrViewName, clientTimeStamp, legitimateChildViews,
orphanChildViews,
findJustOneLegitimateChildView);
- return new Pair<>(legitimateChildViews, orphanChildViews);
}
- private static void findAllDescendantViews(Table sysCatOrsysChildLink,
- Configuration serverSideConfig, byte[] parentTenantId, byte[]
parentSchemaName,
- byte[] parentTableOrViewName, long clientTimeStamp, List<PTable>
legitimateChildViews,
- List<TableInfo> orphanChildViews, boolean
findJustOneLegitimateChildView)
+ public static Pair<List<PTable>, List<TableInfo>>
findAllDescendantViews(Table sysCatOrsysChildLink,
+ Configuration serverSideConfig, byte[] parentTenantId, byte[]
parentSchemaName,
+ byte[] parentTableOrViewName, long clientTimeStamp, List<PTable>
legitimateChildViews,
+ List<TableInfo> orphanChildViews, boolean
findJustOneLegitimateChildView)
+ throws IOException, SQLException{
+
+ return findAllDescendantViews(sysCatOrsysChildLink, null,
serverSideConfig,
+ parentTenantId, parentSchemaName, parentTableOrViewName,
clientTimeStamp,
+ legitimateChildViews, orphanChildViews,
findJustOneLegitimateChildView,
+ new Pair<>(false, false));
+
+ }
+
Review Comment:
nit: Can u add some comments for the new methods and hierarchy traversal
> Support TTL for views using the new column TTL in SYSTEM.CATALOG
> ----------------------------------------------------------------
>
> Key: PHOENIX-7040
> URL: https://issues.apache.org/jira/browse/PHOENIX-7040
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Jacob Isaac
> Assignee: Lokesh Khurana
> Priority: Major
>
> Allow views to be created with TTL specs.
> Ensure TTL is specified only once in the view hierarchy.
> Child views should inherit TTL values from their parent, when not specified
> for the given view.
> Indexes should inherit the TTL values from the base tables/views.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
