[
https://issues.apache.org/jira/browse/PHOENIX-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815059#comment-17815059
]
ASF GitHub Bot commented on PHOENIX-7040:
-----------------------------------------
jpisaac commented on code in PR #1782:
URL: https://github.com/apache/phoenix/pull/1782#discussion_r1480802465
##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java:
##########
@@ -1617,66 +1620,98 @@ private PTable getTableFromCells(List<Cell>
tableCellList, List<List<Cell>> allC
return builder.build();
}
+ /**
+ * Method to return TTL value defined at current level ot up the Hierarchy
of the view.
Review Comment:
nit: typo "or"?
##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java:
##########
@@ -1617,66 +1620,98 @@ private PTable getTableFromCells(List<Cell>
tableCellList, List<List<Cell>> allC
return builder.build();
}
+ /**
+ * Method to return TTL value defined at current level ot up the Hierarchy
of the view.
+ * @param viewKey Key of the view for which we have to find TTL
+ * @param clientTimeStamp Client TimeStamp
+ * @return TTL value for a given view, if nothing is defined anywhere then
return
+ * TTL_NOT_DEFINED(0).
+ * @throws IOException
+ * @throws SQLException
+ */
+
Review Comment:
nit: scanTTLFromParent should be called getTTLFromHierarchy WDT?
> Support TTL for views using the new column TTL in SYSTEM.CATALOG
> ----------------------------------------------------------------
>
> Key: PHOENIX-7040
> URL: https://issues.apache.org/jira/browse/PHOENIX-7040
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Jacob Isaac
> Assignee: Lokesh Khurana
> Priority: Major
>
> Allow views to be created with TTL specs.
> Ensure TTL is specified only once in the view hierarchy.
> Child views should inherit TTL values from their parent, when not specified
> for the given view.
> Indexes should inherit the TTL values from the base tables/views.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
