palashc commented on PR #1744: URL: https://github.com/apache/phoenix/pull/1744#issuecomment-1843409605
@shahrs87 I made the suggested name changes and added a test. Something I noticed when writing a test for the server side metrics - When we create an index on a table without async, we do 2 cache invalidations - one to invalidate the table entry and one to invalidate index entry because index state is updated. Could this be a problem for index creation in prod where we might encounter errors interacting with 100s of region servers? Maybe the second invalidation is not needed when a new index is created since none of the region servers know about it yet, or can we piggy back the table invalidation on the index invalidation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
