palashc commented on PR #1744: URL: https://github.com/apache/phoenix/pull/1744#issuecomment-1846580671
> Also the newly introduced metric failed in the latest run. https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1744/9/testReport/org.apache.phoenix.cache/ServerMetadataCacheTest/testServerSideMetrics/ @shahrs87 The test passed on my local but failed here because there was one extra query in the background from [TaskRegionObserver](https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java#L166). It runs every minute and looks for any tasks to execute. In the jenkins run, the SYSTEM.TASK query coincided with the new test and caused the failure. I had two questions about this: 1. Do you think we should never replace System tables from ServerMetadataCache ? 2. Should we exclude System tables from these new metrics or should I create separate metrics for tracking validateDDL requests and cache hit/miss for system tables? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
