[
https://issues.apache.org/jira/browse/PHOENIX-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798942#comment-17798942
]
ASF GitHub Bot commented on PHOENIX-7006:
-----------------------------------------
haridsv commented on code in PR #1751:
URL: https://github.com/apache/phoenix/pull/1751#discussion_r1432618790
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java:
##########
@@ -1699,6 +1701,44 @@ public void testCreateTableWithNoVerify() throws
SQLException, IOException, Inte
}
}
+ @Test
+ public void testCreateTableWithTableLevelMaxLookbackAge() throws Exception
{
+ String schemaName = generateUniqueName();
+ String dataTableName = generateUniqueName();
+ String fullTableName = SchemaUtil.getTableName(schemaName,
dataTableName);
+ Long maxLookbackAge = 259200L;
+ createTableWithTableLevelMaxLookbackAge(fullTableName,
maxLookbackAge.toString());
+ assertEquals(maxLookbackAge, queryTableLevelMaxLookbackAge(schemaName,
dataTableName));
+ schemaName = generateUniqueName();
+ dataTableName = generateUniqueName();
+ fullTableName = SchemaUtil.getTableName(schemaName, dataTableName);
+ maxLookbackAge = 25920000000L;
+ createTableWithTableLevelMaxLookbackAge(fullTableName,
maxLookbackAge.toString());
+ assertEquals(maxLookbackAge, queryTableLevelMaxLookbackAge(schemaName,
dataTableName));
+ }
+
+ @Test
+ public void testCreateTableWithTableLevelMaxLookbackAgeAsNull() throws
Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = generateUniqueName();
+ String fullTableName = SchemaUtil.getTableName(schemaName,
dataTableName);
+ createTableWithTableLevelMaxLookbackAge(fullTableName, "NULL");
+ assertNull(queryTableLevelMaxLookbackAge(schemaName, dataTableName));
+ schemaName = generateUniqueName();
+ dataTableName = generateUniqueName();
+ fullTableName = SchemaUtil.getTableName(schemaName, dataTableName);
+ createTableWithTableLevelMaxLookbackAge(fullTableName, "null");
Review Comment:
This variant is not nneeded, it is really only testing the parser literal
token.
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java:
##########
@@ -1727,4 +1767,26 @@ private int checkGuidePostWidth(String tableName) throws
Exception {
}
}
+ private void createTableWithTableLevelMaxLookbackAge(String fullTableName,
String maxLookbackAge) throws Exception {
+ try(Connection conn = DriverManager.getConnection(getUrl())) {
+ String createDdl = "CREATE TABLE " + fullTableName +
+ " (id char(1) NOT NULL," + " col1 integer NOT NULL," + "
col2 bigint NOT NULL," +
+ " CONSTRAINT NAME_PK PRIMARY KEY (id, col1, col2)) " +
+ "MAX_LOOKBACK_AGE="+maxLookbackAge;
Review Comment:
As I commented earlier, there is no need to use anything but the simplest
table schema here.
> Configure maxLookbackAge at table level
> ---------------------------------------
>
> Key: PHOENIX-7006
> URL: https://issues.apache.org/jira/browse/PHOENIX-7006
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Sanjeet Malhotra
> Priority: Major
>
> Phoenix max lookback age feature preserves live or deleted row versions that
> are only visible through the max lookback window, it does not preserve any
> unwanted row versions that should not be visible through the max lookback
> window. More details on the max lookback redesign: PHOENIX-6888
> As of today, maxlookback age is only configurable at the cluster level
> (config key: {_}phoenix.max.lookback.age.seconds{_}), meaning the same value
> is used by all tables. This does not allow individual table level compaction
> scanner to be able to retain data based on the table level maxlookback age.
> Setting max lookback age at the table level can serve multiple purposes e.g.
> change-data-capture (PHOENIX-7001) for individual table should have it's own
> latest data retention period.
> The purpose of this Jira is to allow maxlookback age as a table level
> property:
> * New column in SYSTEM.CATALOG to preserve table level maxlookback age
> * PTable object to read the value of maxlookback from SYSTEM.CATALOG
> * Allow CREATE/ALTER TABLE DDLs to provide maxlookback attribute
> * CompactionScanner should use table level maxlookbackAge, if available,
> else use cluster level config
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
