[
https://issues.apache.org/jira/browse/PHOENIX-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819028#comment-17819028
]
ASF GitHub Bot commented on PHOENIX-7006:
-----------------------------------------
kadirozde commented on code in PR #1751:
URL: https://github.com/apache/phoenix/pull/1751#discussion_r1496726438
##########
phoenix-core-client/src/main/java/org/apache/phoenix/compile/QueryCompiler.java:
##########
@@ -190,8 +192,20 @@ private void verifySCN() throws SQLException {
if (scn == null) {
return;
}
- long maxLookBackAgeInMillis =
-
BaseScannerRegionObserverConstants.getMaxLookbackInMillis(conn.getQueryServices().getConfiguration());
+ ColumnResolver resolver = FromCompiler.getResolverForQuery(select,
conn);
Review Comment:
I do not think we need to get a new ColumnResolver here. Can we use the
column resolver of the QueryCompiler object. Please note
FromCompiler.getResolverForQuery() makes an RPC call to the syscat region.
> Configure maxLookbackAge at table level
> ---------------------------------------
>
> Key: PHOENIX-7006
> URL: https://issues.apache.org/jira/browse/PHOENIX-7006
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Sanjeet Malhotra
> Priority: Major
>
> Phoenix max lookback age feature preserves live or deleted row versions that
> are only visible through the max lookback window, it does not preserve any
> unwanted row versions that should not be visible through the max lookback
> window. More details on the max lookback redesign: PHOENIX-6888
> As of today, maxlookback age is only configurable at the cluster level
> (config key: {_}phoenix.max.lookback.age.seconds{_}), meaning the same value
> is used by all tables. This does not allow individual table level compaction
> scanner to be able to retain data based on the table level maxlookback age.
> Setting max lookback age at the table level can serve multiple purposes e.g.
> change-data-capture (PHOENIX-7001) for individual table should have it's own
> latest data retention period.
> The purpose of this Jira is to allow maxlookback age as a table level
> property:
> * New column in SYSTEM.CATALOG to preserve table level maxlookback age
> * PTable object to read the value of maxlookback from SYSTEM.CATALOG
> * Allow CREATE/ALTER TABLE DDLs to provide maxlookback attribute
> * CompactionScanner should use table level maxlookbackAge, if available,
> else use cluster level config
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
