kadirozde commented on code in PR #1736:
URL: https://github.com/apache/phoenix/pull/1736#discussion_r1449292219
##########
phoenix-core-client/src/main/java/org/apache/phoenix/iterate/OrderedResultIterator.java:
##########
@@ -301,21 +415,51 @@ private PeekingResultIterator getResultIterator() throws
SQLException {
}
queueEntries.add(new ResultEntry(sortKeys, result));
if (EnvironmentEdgeManager.currentTimeMillis() - startTime >=
pageSizeMs) {
- dummyTuple = getDummyTuple(result);
- return resultIterator;
+ return getDummyResult();
}
}
resultIteratorReady = true;
this.byteSize = queueEntries.getByteSize();
} catch (IOException e) {
+ LOGGER.error("Error while getting result iterator from
OrderedResultIterator.", e);
ClientUtil.createIOException(e.getMessage(), e);
+ throw new SQLException(e);
} finally {
delegate.close();
}
return resultIterator;
}
+ /**
+ * Retrieve dummy rowkey and return to the client.
+ *
+ * @return the result iterator.
+ */
+ private PeekingResultIterator getDummyResult() {
Review Comment:
This should not return PeekingResultIterator. Should it be private void
updateDummyResult()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
